From 7547c4c77c1feef64a247c3c091ba995ff1de03c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20M=C3=BChlstrasser?= Date: Tue, 17 Sep 2019 20:03:51 +0200 Subject: [PATCH] Address review comments - removed typo from comment - removed redundant AND instruction --- libsrc/osic1p/cgetc.s | 2 +- libsrc/osic1p/kbhit.s | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libsrc/osic1p/cgetc.s b/libsrc/osic1p/cgetc.s index 56209ff6b..380353b77 100644 --- a/libsrc/osic1p/cgetc.s +++ b/libsrc/osic1p/cgetc.s @@ -21,7 +21,7 @@ _cgetc: lda (SCREEN_PTR),y ; fetch current character sta tmp1 ; save it lda #$A1 ; full white square - sta (SCREEN_PTR),y ; store at cursor position^ + sta (SCREEN_PTR),y ; store at cursor position nocursor: jsr _kbhit ; get input character in A diff --git a/libsrc/osic1p/kbhit.s b/libsrc/osic1p/kbhit.s index db28854f5..122a81c6d 100644 --- a/libsrc/osic1p/kbhit.s +++ b/libsrc/osic1p/kbhit.s @@ -72,7 +72,7 @@ LFD1F: jsr LFE86 ; Shift to find bit that is set (in Y) lsr a ; Shift out bit zero (only key there is ) asl a ; And shift back jsr LFE86 ; Shift to find bit that is set (in Y) - beq LFD47 ; Branch if no keys pressed STM: IS THIS CORRECT? + beq LFD47 ; Branch if no keys pressed lda #$00 LFD3A: sta CTRLSHIFT ; Save state of and shift keys LFD3D: sta LASTSCAN @@ -106,7 +106,6 @@ LFD68: stx DBNCCNT jsr LFCBE ; Write keyboard row jsr LFCCF ; Read keyboard column sta KBDTMP - and #$01 tax lda KBDTMP and #$06