the10thwiz/cc65
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Optional warning for implicit constant conversion overflow

Browse Source
This commit is contained in:
bbbradsmith
2023-05-02 22:27:28 -04:00
parent bf5b37a3b2
commit 409235aee6
4 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/cc65.sgml
View File

@@ -754,6 +754,8 @@ Here is a description of all the command line options:
Warn about unused function parameters. Warn about unused function parameters.
<tag><tt/unused-var/</tag> <tag><tt/unused-var/</tag>
Warn about unused variables. Warn about unused variables.
<tag><tt/const-overflow/</tag>
Warn if numerical constant conversion implies overflow. (Disabled by default.)
</descrip> </descrip>
The full list of available warning names can be retrieved by using the The full list of available warning names can be retrieved by using the

2
src/cc65/error.c
View File

@@ -79,6 +79,7 @@ IntStack WarnUnusedLabel = INTSTACK(1); /* - unused labels */
IntStack WarnUnusedParam = INTSTACK(1); /* - unused parameters */ IntStack WarnUnusedParam = INTSTACK(1); /* - unused parameters */
IntStack WarnUnusedVar = INTSTACK(1); /* - unused variables */ IntStack WarnUnusedVar = INTSTACK(1); /* - unused variables */
IntStack WarnUnusedFunc = INTSTACK(1); /* - unused functions */ IntStack WarnUnusedFunc = INTSTACK(1); /* - unused functions */
IntStack WarnConstOverflow = INTSTACK(0); /* - overflow conversion of numerical constants */
/* Map the name of a warning to the intstack that holds its state */ /* Map the name of a warning to the intstack that holds its state */
typedef struct WarnMapEntry WarnMapEntry; typedef struct WarnMapEntry WarnMapEntry;
@@ -102,6 +103,7 @@ static WarnMapEntry WarnMap[] = {
{ &WarnUnusedLabel, "unused-label" }, { &WarnUnusedLabel, "unused-label" },
{ &WarnUnusedParam, "unused-param" }, { &WarnUnusedParam, "unused-param" },
{ &WarnUnusedVar, "unused-var" }, { &WarnUnusedVar, "unused-var" },
{ &WarnConstOverflow, "const-overflow" },
}; };
Collection DiagnosticStrBufs; Collection DiagnosticStrBufs;

1
src/cc65/error.h
View File

@@ -76,6 +76,7 @@ extern IntStack WarnUnusedLabel; /* - unused labels */
extern IntStack WarnUnusedParam; /* - unused parameters */ extern IntStack WarnUnusedParam; /* - unused parameters */
extern IntStack WarnUnusedVar; /* - unused variables */ extern IntStack WarnUnusedVar; /* - unused variables */
extern IntStack WarnUnusedFunc; /* - unused functions */ extern IntStack WarnUnusedFunc; /* - unused functions */
extern IntStack WarnConstOverflow; /* - overflow conversion of numerical constants */
/* Forward */ /* Forward */
struct StrBuf; struct StrBuf;

5
src/cc65/typeconv.c
View File

@@ -128,6 +128,7 @@ static void DoConversion (ExprDesc* Expr, const Type* NewType)
** internally already represented by a long. ** internally already represented by a long.
*/ */
if (NewBits <= OldBits) { if (NewBits <= OldBits) {
unsigned long OldVal = Expr->IVal;
/* Cut the value to the new size */ /* Cut the value to the new size */
Expr->IVal &= (0xFFFFFFFFUL >> (32 - NewBits)); Expr->IVal &= (0xFFFFFFFFUL >> (32 - NewBits));
@@ -139,6 +140,10 @@ static void DoConversion (ExprDesc* Expr, const Type* NewType)
Expr->IVal |= shl_l (~0UL, NewBits); Expr->IVal |= shl_l (~0UL, NewBits);
} }
} }
if ((OldVal != Expr->IVal) && IS_Get (&WarnConstOverflow)) {
Warning ("Implicit conversion of constant overflows %d-bit destination", NewBits);
}
} }
/* Do the integer constant <-> absolute address conversion if necessary */ /* Do the integer constant <-> absolute address conversion if necessary */