the10thwiz/cc65
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Address code review comments

Browse Source
This commit is contained in:
Colin Leroy-Mira
2023-10-11 12:54:12 +02:00
committed by Oliver Schmidt
parent 39d6080945
commit e90a8f3123
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
libsrc/apple2/ser/a2.gs.s
View File

@@ -305,7 +305,7 @@ SER_CLOSE:
stx Opened ; Mark port as closed stx Opened ; Mark port as closed
cli cli
: txa : txa ; Promote char return value
rts rts
;---------------------------------------------------------------------------- ;----------------------------------------------------------------------------
@@ -313,13 +313,17 @@ SER_CLOSE:
; Must return an SER_ERR_xx code in a/x. ; Must return an SER_ERR_xx code in a/x.
SER_OPEN: SER_OPEN:
bit $C082 ; Check if this is a IIgs ; Check if this is a IIgs (Apple II Miscellaneous TechNote #7,
; Apple II Family Identification)
sec sec
jsr $FE1F ; https://prodos8.com/docs/technote/misc/07/ bit $C082
jsr $FE1F
bit $C080
bcc IIgs bcc IIgs
bit $C080
lda #SER_ERR_NO_DEVICE ; Not a IIgs lda #SER_ERR_NO_DEVICE ; Not a IIgs
SetupErrOut: SetupErrOut:
cli cli
ldx #$00 ; Promote char return value ldx #$00 ; Promote char return value
@@ -327,8 +331,7 @@ SetupErrOut:
rts rts
IIgs: IIgs:
bit $C080 sei
sei ; Disable interrupts
; Check if the handshake setting is valid ; Check if the handshake setting is valid
ldy #SER_PARAMS::HANDSHAKE ; Handshake ldy #SER_PARAMS::HANDSHAKE ; Handshake