Treat signed int bit-fields as signed
Prior to this PR, `int`, `signed int`, and `unsigned int` bitfields are all treated as `unsigned int`. With this PR, `signed int` will be treated as `signed int`, and the others remain unsigned. Since `Type` does not distinguish between `int` and `signed int`, add an extra `int* SignenessSpecified` param to `ParseTypeSpec` so we can tell these apart for bit-fields and treat plain `int : N` as `unsigned int : N` since it is more efficient to zero-extend than sign-extend. Fixes #1095
This commit is contained in:
Jesse Rosenstock
committed by
Oliver Schmidt
Oliver Schmidt
parent
55cebc7b9e
commit
ff535b8e1a
162
test/val/bug1095.c
Normal file
162
test/val/bug1095.c
Normal file
@@ -0,0 +1,162 @@
|
||||
/*
|
||||
Copyright 2020 Google LLC
|
||||
|
||||
This software is provided 'as-is', without any express or implied
|
||||
warranty. In no event will the authors be held liable for any damages
|
||||
arising from the use of this software.
|
||||
|
||||
Permission is granted to anyone to use this software for any purpose,
|
||||
including commercial applications, and to alter it and redistribute it
|
||||
freely, subject to the following restrictions:
|
||||
|
||||
1. The origin of this software must not be misrepresented; you must not
|
||||
claim that you wrote the original software. If you use this software
|
||||
in a product, an acknowledgment in the product documentation would be
|
||||
appreciated but is not required.
|
||||
2. Altered source versions must be plainly marked as such, and must not be
|
||||
misrepresented as being the original software.
|
||||
3. This notice may not be removed or altered from any source distribution.
|
||||
*/
|
||||
|
||||
/*
|
||||
Tests of signed bit-fields; see https://github.com/cc65/cc65/issues/1095
|
||||
*/
|
||||
|
||||
#include <stdio.h>
|
||||
|
||||
static unsigned char failures = 0;
|
||||
|
||||
static struct signed_ints {
|
||||
signed int a : 3;
|
||||
signed int b : 3;
|
||||
signed int c : 3;
|
||||
signed int d : 10;
|
||||
signed int : 0;
|
||||
signed int e : 8;
|
||||
signed int f : 16;
|
||||
} si = {-4, -1, 3, -500, -100, -5000};
|
||||
|
||||
static void test_signed_bitfield(void)
|
||||
{
|
||||
if (si.a >= 0) {
|
||||
printf("Got si.a = %d, expected negative.\n", si.a);
|
||||
failures++;
|
||||
}
|
||||
if (si.a != -4) {
|
||||
printf("Got si.a = %d, expected -4.\n", si.a);
|
||||
failures++;
|
||||
}
|
||||
|
||||
if (si.b >= 0) {
|
||||
printf("Got si.b = %d, expected negative.\n", si.b);
|
||||
failures++;
|
||||
}
|
||||
if (si.b != -1) {
|
||||
printf("Got si.b = %d, expected -1.\n", si.b);
|
||||
failures++;
|
||||
}
|
||||
|
||||
if (si.c <= 0) {
|
||||
printf("Got si.c = %d, expected positive.\n", si.c);
|
||||
failures++;
|
||||
}
|
||||
if (si.c != 3) {
|
||||
printf("Got si.c = %d, expected 3.\n", si.c);
|
||||
failures++;
|
||||
}
|
||||
|
||||
if (si.d >= 0) {
|
||||
printf("Got si.d = %d, expected negative.\n", si.d);
|
||||
failures++;
|
||||
}
|
||||
if (si.d != -500) {
|
||||
printf("Got si.d = %d, expected -500.\n", si.d);
|
||||
failures++;
|
||||
}
|
||||
|
||||
if (si.e >= 0) {
|
||||
printf("Got si.e = %d, expected negative.\n", si.e);
|
||||
failures++;
|
||||
}
|
||||
if (si.e != -100) {
|
||||
printf("Got si.e = %d, expected -100.\n", si.e);
|
||||
failures++;
|
||||
}
|
||||
|
||||
if (si.f >= 0) {
|
||||
printf("Got si.f = %d, expected negative.\n", si.f);
|
||||
failures++;
|
||||
}
|
||||
if (si.f != -5000) {
|
||||
printf("Got si.f = %d, expected -5000.\n", si.f);
|
||||
failures++;
|
||||
}
|
||||
|
||||
si.a = -3;
|
||||
si.b = 1;
|
||||
si.c = -2;
|
||||
si.d = 500;
|
||||
si.e = 100;
|
||||
si.f = 5000;
|
||||
|
||||
if (si.a >= 0) {
|
||||
printf("Got si.a = %d, expected negative.\n", si.a);
|
||||
failures++;
|
||||
}
|
||||
if (si.a != -3) {
|
||||
printf("Got si.a = %d, expected -3.\n", si.a);
|
||||
failures++;
|
||||
}
|
||||
|
||||
if (si.b <= 0) {
|
||||
printf("Got si.b = %d, expected positive.\n", si.b);
|
||||
failures++;
|
||||
}
|
||||
if (si.b != 1) {
|
||||
printf("Got si.b = %d, expected 1.\n", si.b);
|
||||
failures++;
|
||||
}
|
||||
|
||||
if (si.c >= 0) {
|
||||
printf("Got si.c = %d, expected negative.\n", si.c);
|
||||
failures++;
|
||||
}
|
||||
if (si.c != -2) {
|
||||
printf("Got si.c = %d, expected -2.\n", si.c);
|
||||
failures++;
|
||||
}
|
||||
|
||||
if (si.d <= 0) {
|
||||
printf("Got si.d = %d, expected positive.\n", si.d);
|
||||
failures++;
|
||||
}
|
||||
if (si.d != 500) {
|
||||
printf("Got si.d = %d, expected 500.\n", si.d);
|
||||
failures++;
|
||||
}
|
||||
|
||||
if (si.e <= 0) {
|
||||
printf("Got si.e = %d, expected positive.\n", si.e);
|
||||
failures++;
|
||||
}
|
||||
if (si.e != 100) {
|
||||
printf("Got si.e = %d, expected 100.\n", si.e);
|
||||
failures++;
|
||||
}
|
||||
|
||||
if (si.f <= 0) {
|
||||
printf("Got si.f = %d, expected positive.\n", si.f);
|
||||
failures++;
|
||||
}
|
||||
if (si.f != 5000) {
|
||||
printf("Got si.f = %d, expected 5000.\n", si.f);
|
||||
failures++;
|
||||
}
|
||||
}
|
||||
|
||||
int main(void)
|
||||
{
|
||||
test_signed_bitfield();
|
||||
printf("failures: %u\n", failures);
|
||||
return failures;
|
||||
}
|
||||
Reference in New Issue
Block a user